Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwt extended broken by flask bump #28451

Merged
merged 3 commits into from
May 13, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 13, 2024

SUMMARY

Flask 2.3.0 removed app.json_encoder

https://github.com/pallets/flask/blob/255c8d66af6daff3eaa063ea0819e185d4d1e214/CHANGES.rst#version-230

This property was being used by flask-jwt-extended, fixed here: vimalloc/flask-jwt-extended#493
and released on version 4.4.4

This fixes /api/v1/security/login on Superset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested review from villebro, mistercrunch, Antonio-RiveroMartnez and geido and removed request for villebro May 13, 2024 10:25
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (76d897e) to head (3202bcc).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28451       +/-   ##
===========================================
+ Coverage   60.48%   83.38%   +22.89%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37400    -38836     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31185    -14929     
+ Misses      28017     6215    -21802     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.05% <ø> (-0.12%) ⬇️
javascript ?
mysql 77.09% <ø> (?)
postgres 77.20% <ø> (?)
presto 53.61% <ø> (-0.19%) ⬇️
python 83.38% <ø> (+19.89%) ⬆️
sqlite 76.65% <ø> (?)
unit 58.78% <ø> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar removed the request for review from mistercrunch May 13, 2024 10:46
@dpgaspar dpgaspar merged commit 356a58d into apache:master May 13, 2024
34 of 35 checks passed
@dpgaspar dpgaspar deleted the fix/jwt_extended branch May 13, 2024 16:51
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants