perf: Lazy load rehype-raw and react-markdown #29855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
geido
approved these changes
Aug 5, 2024
WanjohiWanjohi
pushed a commit
to IDinsight/surveystream_superset_source
that referenced
this pull request
Aug 6, 2024
This was referenced Oct 14, 2024
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
betodealmeida
pushed a commit
that referenced
this pull request
Jan 14, 2025
(cherry picked from commit 5b5f448)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Lazy load rehype-raw and react-markdown libraries.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Notice that rehype-raw is now in a separate chunk instead of an entry, meaning that it will only load when there's a markdown component on a dashboard.
Before:
After:
TESTING INSTRUCTIONS
Dashboard should work fine with and without markdown components
ADDITIONAL INFORMATION