-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): fix examples uri for sqlite #30277
fix(examples): fix examples uri for sqlite #30277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30277 +/- ##
===========================================
+ Coverage 60.48% 83.75% +23.27%
===========================================
Files 1931 534 -1397
Lines 76236 38544 -37692
Branches 8568 0 -8568
===========================================
- Hits 46114 32284 -13830
+ Misses 28017 6260 -21757
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cb32a31
to
1752d00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, and restarting E2E failures, but I'm wondering if we need to update this in the tests too.
From superset/.github/workflows/superset-python-integrationtest.yml
test-sqlite:
runs-on: ubuntu-22.04
env:
PYTHONPATH: ${{ github.workspace }}
SUPERSET_CONFIG: tests.integration_tests.superset_test_config
REDIS_PORT: 16379
SUPERSET__SQLALCHEMY_DATABASE_URI: |
sqlite:///${{ github.workspace }}/.temp/superset.db?check_same_thread=true
SUPERSET__SQLALCHEMY_EXAMPLES_URI: |
sqlite:///${{ github.workspace }}/.temp/examples.db?check_same_thread=true
To take it one step further, is there even a case for check_same_thread=true
any more, or can we whittle some code away?
SUMMARY
The PR #25680 fixed the default sqlite connection string for the metastore connection so that it works correctly in an async use case. However, this fix was not applied to the Examples data URI, causing async access to fail.
TESTING INSTRUCTIONS
examples
databaseselect 1
on theexamples
databaseADDITIONAL INFORMATION