refactor(Radio): Upgrade Radio Component to Ant Design 5 #32004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements Radio from Antd5 - Update types in constants file for options constants
- Radio.GroupWrapper customization for Radio.Group component - Replaces Radio.Group in the base code with Radio.GroupWrapper - Optimizes by removing excess code
EnxDev
requested review from
sadpandajoe,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
dosubot
bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Undefined Radio Component Reference ▹ view | ✅ |
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx
Show resolved
Hide resolved
geido
reviewed
Jan 28, 2025
- Improves reusability for the Radio Component - Aligns storybook with component changes
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
|
Missing enableSpaceConfig Control ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/explore/components/controls/DateFilterControl/components/CalendarFrame.tsx | ✅ |
| superset-frontend/src/explore/components/controls/DateFilterControl/components/CommonFrame.tsx | ✅ |
| superset-frontend/src/explore/components/controls/DateFilterControl/components/CurrentCalendarFrame.tsx | ✅ |
| superset-frontend/src/components/Chart/DrillBy/useDisplayModeToggle.tsx | ✅ |
| superset-frontend/src/components/Table/header-renderers/HeaderWithRadioGroup.tsx | ✅ |
| superset-frontend/src/components/Radio/index.tsx | ✅ |
| superset-frontend/src/explore/components/controls/DateFilterControl/utils/constants.ts | ✅ |
| superset-frontend/src/components/Radio/Radio.stories.tsx | ✅ |
| superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx | ✅ |
| superset-frontend/src/explore/components/DataTableControl/index.tsx | ✅ |
| superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx | ✅ |
| superset-frontend/cypress-base/cypress/support/e2e.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
kgabryje
reviewed
Jan 30, 2025
superset-frontend/src/components/Chart/DrillBy/useDisplayModeToggle.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Jan 30, 2025
superset-frontend/src/components/Chart/DrillBy/useDisplayModeToggle.tsx
Outdated
Show resolved
Hide resolved
|
Looks like the radio buttons in drill by are separated 
|
Yes, when I modified the Radio.GroupWrapper, it broke the spacing of the drill-by. I reattached it again, thanks |
- small changes from PR reviews - removes children from Radio.GroupWrapper
|
I believe this broke master CI. 
We need to try to fix it before Monday when we'll cut 5.0. Otherwise, we'll need to revert. |
|
It looks like this was a false alarm and we have another flaky test 😞. It succeeded on the third run. No changes required and thanks for the contribution @EnxDev! |
tmsjordan
pushed a commit
to tmsdevelopment/superset
that referenced
this pull request
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migration of Radio component from Ant Design v4 to Ant Design v5.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Calendar frame before
CalendarFrame after
CommonFrame before
CommonFrame after
CurrentFrame before
CurrentFrame after
DisplayModeToggle before
DisplayModeToggle after
Recording.2025-01-25.193403.mp4
HeaderWithRadioGroup before
HeaderWithRadioGroup after
ReportModal before
ReportModal after
SaveModal before
SaveModal After
Before
before.mp4
after.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION