New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tooltips to sankey #341

Merged

mistercrunch merged 2 commits into master from chris/sankey-improvements

Apr 13, 2016

Contributor

williaster commented Apr 13, 2016

requested by lindsay for next week. will think about cycles in another PR. previously we only supported titles which aren't really tooltips.

@mistercrunch @michellethomas


          add tooltips to sankey

fc90c6a

landscape-bot commented Apr 13, 2016

Code quality remained the same when pulling fc90c6a on airbnb:chris/sankey-improvements into 77828b6 on airbnb:master.


          update tooltip language ('count' --> 'value', 'Link Weight' --> 'Path…

5577bc2

… Value').

landscape-bot commented Apr 13, 2016

Code quality remained the same when pulling 5577bc2 on airbnb:chris/sankey-improvements into 77828b6 on airbnb:master.

coveralls commented Apr 13, 2016

Coverage remained the same at 72.494% when pulling 5577bc2 on chris/sankey-improvements into 77828b6 on master.

coveralls commented Apr 13, 2016

Coverage remained the same at 72.494% when pulling 5577bc2 on chris/sankey-improvements into 77828b6 on master.

Member

mistercrunch commented Apr 13, 2016

oh nice! looks perfect

mistercrunch merged commit 1e08b3e into master

williaster deleted the chris/sankey-improvements branch

April 13, 2016 22:31

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request


          build(deps-dev): bump @types/jest from 25.1.4 to 25.2.1 (apache#341)

017d2e3

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.1.4 to 25.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @types/jest from 25.1.4 to 25.2.1 (apache#341)

da7322c

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.1.4 to 25.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @babel/core from 7.4.5 to 7.8.4 (apache#341)

21ba9c8

Bumps [@babel/core](https://github.com/babel/babel) from 7.4.5 to 7.8.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.4.5...v7.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @types/jest from 25.1.4 to 25.2.1 (apache#341)

4a52982

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.1.4 to 25.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @babel/core from 7.4.5 to 7.8.4 (apache#341)

c0dcf86

Bumps [@babel/core](https://github.com/babel/babel) from 7.4.5 to 7.8.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.4.5...v7.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @types/jest from 25.1.4 to 25.2.1 (apache#341)

2ee9d47

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.1.4 to 25.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @babel/core from 7.4.5 to 7.8.4 (apache#341)

34090fd

Bumps [@babel/core](https://github.com/babel/babel) from 7.4.5 to 7.8.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.4.5...v7.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @types/jest from 25.1.4 to 25.2.1 (apache#341)

ff51f20

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.1.4 to 25.2.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request


          build(deps-dev): bump @babel/core from 7.4.5 to 7.8.4 (apache#341)

Bumps [@babel/core](https://github.com/babel/babel) from 7.4.5 to 7.8.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.4.5...v7.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

mistercrunch added 🏷️ bot 🚢 0.8.7 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot 🚢 0.8.7