Add CORS support #478
Merged
Add CORS support #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Any reason why this stalled? |
| @@ -20,6 +20,7 @@ | |||
| 'cryptography>=1.1.1, <2.0.0', | |||
| 'flask-appbuilder>=1.6.0, <2.0.0', | |||
| 'Flask-BabelPkg==0.9.6', | |||
| 'Flask-Cors>=2.0.0', | |||
There was a problem hiding this comment.
I would rather not have this as a hard dependency for the vast majority. I'd propose removing it or using extra_requires.
|
@mistercrunch I moved flask-cors into an extra dependency, and I also added some documentation, let me know what you think :) |
|
👍 |
|
great, thanks |
6 tasks
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Bumps [datatables.net-bs](https://github.com/DataTables/Dist-DataTables-Bootstrap) from 1.10.20 to 1.10.21. - [Release notes](https://github.com/DataTables/Dist-DataTables-Bootstrap/releases) - [Commits](DataTables/Dist-DataTables-Bootstrap@1.10.20...1.10.21) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Bumps [datatables.net-bs](https://github.com/DataTables/Dist-DataTables-Bootstrap) from 1.10.20 to 1.10.21. - [Release notes](https://github.com/DataTables/Dist-DataTables-Bootstrap/releases) - [Commits](DataTables/Dist-DataTables-Bootstrap@1.10.20...1.10.21) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Bumps [datatables.net-bs](https://github.com/DataTables/Dist-DataTables-Bootstrap) from 1.10.20 to 1.10.21. - [Release notes](https://github.com/DataTables/Dist-DataTables-Bootstrap/releases) - [Commits](DataTables/Dist-DataTables-Bootstrap@1.10.20...1.10.21) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Bumps [datatables.net-bs](https://github.com/DataTables/Dist-DataTables-Bootstrap) from 1.10.20 to 1.10.21. - [Release notes](https://github.com/DataTables/Dist-DataTables-Bootstrap/releases) - [Commits](DataTables/Dist-DataTables-Bootstrap@1.10.20...1.10.21) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am using caravel as an API service, and CORS would be nice for this use case. I just wanted to know if this looks good, before spending time on tests (which I am not sure how to implement, suggestions welcome!)