Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue #5272
The original Regular Expression cannot catch the LIMIT statement when there are extra statements after LIMIT.
Note, the proposed solution is not perfect either.. Currently all the corner case I can think of:
'LIMIT' inside quotes, which causes the false setting of query.limit
SELECT "LIMIT 100" as C, id from aTable
LIMIT number is set larger than
SQL_MAX_ROW
, which causes the additional limit clause addedSELECT * FROM atable LIMIT 10000001 OFFSET 1
get_query_without_limit
function is broken too for the cases shown above.