Add support for "Having" filter in druid #553
Conversation
|
Coverage decreased (-0.3%) to 81.843% when pulling 2adbe19f2f5b03f6df4d17c5cfcdc2e90675a5ed on x4base:having_filter into cb384d0 on airbnb:master. |
|
Coverage decreased (-0.2%) to 81.85% when pulling 2b3df1de8165da8835e1305c9e71b5709a600c21 on x4base:having_filter into cb384d0 on airbnb:master. |
|
Coverage decreased (-0.2%) to 81.85% when pulling f41a05f58dbe3dc4c0dcc144d0dedb59602e4174 on x4base:having_filter into cb384d0 on airbnb:master. |
| @@ -1265,6 +1243,59 @@ def recursive_get_fields(_conf): | |||
| query=query_str, | |||
| duration=datetime.now() - qry_start_dttm) | |||
|
|
|||
| @staticmethod | |||
| def get_filters(filter): | |||
There was a problem hiding this comment.
filter is a standard lib, main namespace function. Here you are redefining it for the scope of this function. Use filter_ or some other name instead.
|
This is great, I finally took the time to test it. The last missing thing for me is to make sure that only metrics are shown in the Having dropdown field. |
|
Do you mean the options should not include dimensions? But sometimes the user may want to filter the dimensions in the post-aggregation stage, right? |
|
Oh, if that works then it's good! |
|
Actually it fails if you try to to use |
|
Sorry I didn't test the filter with strings, it should work now |
|
PR needs a rebase ... |
Support the dimSelector having filters
|
Updated |
mistercrunch
added
🏷️ bot
No description provided.