use_slice_data in slice_json #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5643 +/- ##
=======================================
Coverage 63.51% 63.51%
=======================================
Files 360 360
Lines 22890 22890
Branches 2549 2549
=======================================
Hits 14539 14539
Misses 8336 8336
Partials 15 15
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Aug 16, 2018
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
Aug 16, 2018
(cherry picked from commit 492ad6c)
michellethomas
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 16, 2018
…ce_json_fix use_slice_data in slice_json calls (apache#5643)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be explicitly making sure use_slice_json is true when slice_json calls get_form_data.
@john-bodley @graceguo-supercat