Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllab] log query fetch time #6033

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

timifasubaa
Copy link
Contributor

This PR adds logging for the time spent fetching results from the db cursor

@john-bodley

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #6033 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6033      +/-   ##
==========================================
+ Coverage   64.63%   64.67%   +0.04%     
==========================================
  Files         449      449              
  Lines       23821    23823       +2     
  Branches     2639     2639              
==========================================
+ Hits        15396    15408      +12     
+ Misses       8412     8402      -10     
  Partials       13       13
Impacted Files Coverage Δ
superset/sql_lab.py 71.76% <100%> (+0.33%) ⬆️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5c910...5e2a12f. Read the comment docs.

@timifasubaa timifasubaa merged commit e12d00a into apache:master Oct 4, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants