Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix bar chart value overlap with legend #6145

Merged
merged 1 commit into from
Oct 19, 2018
Merged

[bugfix] fix bar chart value overlap with legend #6145

merged 1 commit into from
Oct 19, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 18, 2018

Bar chart values overlap with legend when "Show bar values" is selected (PRODUCT-59209)

@graceguo-supercat @michellethomas @williaster @conglei

@kristw kristw closed this Oct 19, 2018
@kristw kristw reopened this Oct 19, 2018
@codecov-io
Copy link

codecov-io commented Oct 19, 2018 •
edited
Loading

Codecov Report

Merging #6145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6145   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files          47       47           
  Lines        9362     9362           
=======================================
  Hits         7201     7201           
  Misses       2161     2161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d662e36...1d2038f. Read the comment docs.

williaster
williaster approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@williaster williaster merged commit bc4dfad into apache:master Oct 19, 2018
@kristw kristw deleted the kristw-bar-value branch October 19, 2018 01:02
@kristw kristw mentioned this pull request Dec 24, 2018
Closed
3 tasks
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@kristw @bipinsoniguavus
fix bar chart value overlap with legend (apache#6145)
a0c6c89
@wtfzambo
Copy link

wtfzambo commented Oct 23, 2019 •
edited
Loading

Incurred in this issue today pretty much as described in #3779 .

Screenshot for reference.
issue

@wtfzambo wtfzambo mentioned this pull request Oct 30, 2019
Closed
@Neel-rishabhsoft
Copy link

#8480 (comment)

@matrix-compute matrix-compute mentioned this pull request Dec 27, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Dec 27, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jan 5, 2024
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

@michellethomas michellethomas michellethomas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kristw @codecov-io @wtfzambo @Neel-rishabhsoft @michellethomas @williaster @mistercrunch