Fixed the cache issue for BigNumber #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2018 12:16
|
Tested on devbox and this works. Thanks for fixing this! |
timifasubaa
approved these changes
Nov 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #6375 +/- ##
=======================================
Coverage 77.34% 77.34%
=======================================
Files 67 67
Lines 9583 9583
=======================================
Hits 7412 7412
Misses 2171 2171
Continue to review full report at Codecov.
|
williaster
approved these changes
Nov 12, 2018
conglei
added a commit
to conglei/incubator-superset
that referenced
this pull request
Nov 12, 2018
* fixed the cache issue for bignumber * fixed (cherry picked from commit 8e2d28d)
conglei
added a commit
to airbnb/superset-fork
that referenced
this pull request
Nov 12, 2018
Fixed the cache issue for BigNumber (apache#6375)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Nov 20, 2018
* fixed the cache issue for bignumber * fixed (cherry picked from commit 8e2d28d)
mistercrunch
pushed a commit
that referenced
this pull request
Nov 30, 2018
* fixed the cache issue for bignumber * fixed (cherry picked from commit 8e2d28d)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* fixed the cache issue for bignumber * fixed
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fixed the cache issue for bignumber * fixed (cherry picked from commit 11c55ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue that for BigNumber (which uses the
get_datafunction in BaseVis),get_datawill always conduct a query no matter the result is cached or not.@graceguo-supercat @kristw @williaster