Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aggregates from metric options if datasource has no columns #7586

Merged
merged 1 commit into from
May 24, 2019
Merged

Remove aggregates from metric options if datasource has no columns #7586

merged 1 commit into from
May 24, 2019

Conversation

michellethomas
Copy link
Contributor

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

In the rare case that a datasource doesn't have columns, we should avoid showing aggregates in the metrics control dropdown because they wouldn't be relevant without columns to use them with.

TEST PLAN

Create a datasource with no columns (only metrics)
Check the metrics dropdown to make sure SUM, MIN, MAX aggregates don't show up

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat @kristw

graceguo-supercat
graceguo-supercat approved these changes May 23, 2019
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michellethomas michellethomas merged commit 47ba2ad into apache:master May 24, 2019
@michellethomas michellethomas deleted the metric_control_no_cols_no_aggregates branch May 24, 2019 18:10
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 31, 2019
@michellethomas
Remove aggregates from metric options if datasource has no columns (a…
454860b 
…pache#7586)

(cherry picked from commit 47ba2ad)
michellethomas added a commit that referenced this pull request Jun 1, 2019
@michellethomas
Remove aggregates from metric options if datasource has no columns (#…
99de5a4 
…7586)

(cherry picked from commit 47ba2ad)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michellethomas
Remove aggregates from metric options if datasource has no columns (a…
08a4b72 
…pache#7586)

(cherry picked from commit c220a6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michellethomas @graceguo-supercat @mistercrunch