Fix tooltips not visible for NVD3 charts on Firefox (#7822) #7929
Conversation
|
Could you add screenshots to show the before/after of the change? Thanks! |
|
Sure. Before (note the highlighted dots in the chart on the left from hovering):
After:
|
|
You may have to rebase because of Travis issues. Also can you confirm this doesn't break Chrome? |
Codecov Report
@@ Coverage Diff @@
## master #7929 +/- ##
==========================================
+ Coverage 65.59% 65.97% +0.37%
==========================================
Files 469 468 -1
Lines 22401 22297 -104
Branches 2432 2429 -3
==========================================
+ Hits 14694 14710 +16
+ Misses 7586 7466 -120
Partials 121 121
Continue to review full report at Codecov.
|
|
Rebase done. I cannot spot any visual differences in Chrome – nor in Firefox apart from the tooltips being back. I don't have access to IE/Edge or Safari but according to caniuse the |
|
I don't think the rebase worked properly, your PR now has commits that shouldn't be there... |
schoel-bis
force-pushed
the
fix-firefox-tooltips
branch
from
cf708ab to
65782d1
Compare
schoel-bis
force-pushed
the
fix-firefox-tooltips
branch
from
65782d1 to
81eb344
Compare
This bug was introduced by apache#7102 Using `position:absolute` on body gives `document.documentElement` a height of 0 which propagates to `clientHeight` on Firefox. This leads to a wrong calculation of the tooltip position in NVD3. The solution proposed here is to use `min-height: 100vh` instead of the current technique for stretching the body element to the full window height, thus keeping body and html together.
schoel-bis
force-pushed
the
fix-firefox-tooltips
branch
from
81eb344 to
5c795b4
Compare
|
@mistercrunch I think this is good to merge |
) (apache#7929)" This reverts commit 6df2a71.
|
@schoel-bis This PR has to be reverted from Master branch. Please see details in #8147. |
CATEGORY
Choose one
SUMMARY
The bug was introduced by #7102
Using
position:absoluteon body givesdocument.documentElementa height of 0 which propagates toclientHeighton Firefox. This leads to a wrong calculation of the tooltip position in NVD3.The solution proposed here is to use
min-height: 100vhinstead of the current technique for stretching the body element to the full window height, thus keeping body and html together.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Access an NVD3 based chart in Firefox and hover with mouse.
ADDITIONAL INFORMATION
REVIEWERS