[js linting] use airbnb eslint settings

[ascott]

• extends airbnb's eslint package, with a few custom rules
• lints most js files (everything but the visualizations and spec folders for now)
• adds linting to the npm run test step so tests will fail if linting fails

core flows to test:

• add new slice from dashboard
• saving position changes on a dashboard
• viewing a dashboard
• viewing a slice
• changing a filter on a slice
• creating a new slice
• adding a slice to a dashboard
• saving size changes on a dashboard
• exploring a chart from a dashboard
• refreshing cache on a chart (in explore or on dashboard)
• view a standalone chart from the explore page
• exporting chart data as csv/json
• remove chart from dashboard
• edit dashboard css
• view dashboard filters
• viewing /welcome

plz review @mistercrunch @williaster

[coveralls]

Coverage remained the same at 81.185% when pulling 6b826b3661153e17de03e4f4565b01adb08660ee on ascott:alanna-eslint-jshint into a704d4d on airbnb:master.

[ascott]

@mistercrunch @williaster @georgeke any other flows you think i'm missing here for testing?

[williaster]

maybe

• remove chart from dashboard
• saving size/position changes on a dashboard
• exploring a chart from a dashboard
• refreshing cache on a chart (in explore or on dashboard)
• view a standalone chart from the explore page
• exporting chart data as csv/json
• favoriting a chart or dashboard
• checking for size updates on window.resize?

not sure about adding/testing a new data source or not. I think the most susceptible place for bugs might be the python / js interface where there could be camelCase / underscore case mismatches.

[ascott]

great suggestions, thanks @williaster!

[coveralls]

Coverage remained the same at 81.012% when pulling 1d88a02 on ascott:alanna-eslint-jshint into f43e5f1 on airbnb:master.

[coveralls]

Coverage remained the same at 81.012% when pulling 1d88a02 on ascott:alanna-eslint-jshint into f43e5f1 on airbnb:master.