Allow resizing width of SQL Lab left bar / editor #8099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Split | ||
| ref={this.sqlEditorRef} | ||
| className={this.props.hideLeftBar ? 'SqlEditor-expanded' : 'SqlEditor'} | ||
| sizes={[INITIAL_WEST_PERCENT, INITIAL_EAST_PERCENT]} |
There was a problem hiding this comment.
do you want user's setting be persist when they reload page or switch tabs?
There was a problem hiding this comment.
I don't think this should be persisted, since in my experience it's more circumstantial. For some of our tables the metadata is too big and users want momentarily to expand it. What are your thoughts?
betodealmeida
changed the title
betodealmeida
added
enhancement:request
khtruong
approved these changes
Aug 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #8099 +/- ##
=========================================
- Coverage 65.93% 65.9% -0.04%
=========================================
Files 485 485
Lines 22887 22925 +38
Branches 2521 2538 +17
=========================================
+ Hits 15090 15108 +18
- Misses 7666 7685 +19
- Partials 131 132 +1
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 29, 2019
etr2460
pushed a commit
to etr2460/incubator-superset
that referenced
this pull request
Aug 30, 2019
This reverts commit ed3360b.
graceguo-supercat
pushed a commit
that referenced
this pull request
Aug 30, 2019
|
I am strugging to get this to work in version 35.2. Any ideas why that could be? |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR adds a gutter for resizing the width of SQL Lab left bar and editor. Currently, the setting is not persisted, since in the cases we observed the use was more circumstantial.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Note that the gutter is not vertically centered, which I found more intuitive. I can move it to the center.
TEST PLAN
See video above.
ADDITIONAL INFORMATION
REVIEWERS
@etr2460 @graceguo-supercat