Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove PY3 conditional logic #8149

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

mistercrunch
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Remove Python 3 conditional logic

@codecov-io
Copy link

Codecov Report

Merging #8149 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8149      +/-   ##
=========================================
- Coverage    66.2%   66.2%   -0.01%     
=========================================
  Files         479     479              
  Lines       22936   22930       -6     
  Branches     2524    2524              
=========================================
- Hits        15184   15180       -4     
+ Misses       7618    7616       -2     
  Partials      134     134
Impacted Files Coverage Δ
superset/utils/core.py 88.05% <83.33%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abec19...d477104. Read the comment docs.

@mistercrunch mistercrunch merged commit ee24539 into apache:master Sep 2, 2019
@mistercrunch mistercrunch deleted the py3k_deref branch September 2, 2019 19:46
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants