Forward SIGTERM signal to gunicorn #8156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently docker entrypoint is a bash script. `docker stop` command (or restart in kubernetes) sends SIGTERM to the container but it isn't catched by gunicorn. So gunicorn can't start graceful shutdown which may lead to killing user's connection and also adds 10s (default value) delay for stopping until docker sends SIGKILL. Using `exec` replaces the shell with the process being opened and signals are propagated correctly. Ref: https://docs.docker.com/engine/reference/commandline/stop/ Ref: https://unix.stackexchange.com/questions/146756/forward-sigterm-to-child-in-bash
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #8156 +/- ##
======================================
Coverage 66.2% 66.2%
======================================
Files 479 479
Lines 22936 22936
Branches 2524 2524
======================================
Hits 15184 15184
Misses 7618 7618
Partials 134 134Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Sep 2, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Currently docker entrypoint is a bash script.
docker stopcommand (or restart in kubernetes) sends SIGTERM to thecontainer but it isn't catched by gunicorn.
So gunicorn can't start graceful shutdown which may lead to killing
user's connection and also adds 10s (default value) delay for stopping
until docker sends SIGKILL.
Using
execreplaces the shell with the process being opened andsignals are propagated correctly.
Ref: https://docs.docker.com/engine/reference/commandline/stop/
Ref: https://unix.stackexchange.com/questions/146756/forward-sigterm-to-child-in-bash
TEST PLAN
Run superset in docker container and execute
docker stopon master it would result in:Run superset in docker container and execute
docker stopfrom this branch it would result in:ADDITIONAL INFORMATION
REVIEWERS