Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapbox radius calculations being off when changing latitude #824

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

georgeke
Copy link
Contributor

Instead of passing the latitude of the center of the viewport, pass the latitude of the point which radius is being calculate for. Currently, the radius of points will change slightly based on what the viewport latitude is.

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage remained the same at 81.012% when pulling d8d8a78 on georgeke:map-calculation-fix into f43e5f1 on airbnb:master.

@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit f9427b9 into apache:master Jul 28, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
Bumps [xss](https://github.com/leizongmin/js-xss) from 1.0.6 to 1.0.8.
- [Release notes](https://github.com/leizongmin/js-xss/releases)
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md)
- [Commits](leizongmin/js-xss@v1.0.6...v1.0.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
Bumps [xss](https://github.com/leizongmin/js-xss) from 1.0.6 to 1.0.8.
- [Release notes](https://github.com/leizongmin/js-xss/releases)
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md)
- [Commits](leizongmin/js-xss@v1.0.6...v1.0.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
Bumps [xss](https://github.com/leizongmin/js-xss) from 1.0.6 to 1.0.8.
- [Release notes](https://github.com/leizongmin/js-xss/releases)
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md)
- [Commits](leizongmin/js-xss@v1.0.6...v1.0.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Bumps [xss](https://github.com/leizongmin/js-xss) from 1.0.6 to 1.0.8.
- [Release notes](https://github.com/leizongmin/js-xss/releases)
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md)
- [Commits](leizongmin/js-xss@v1.0.6...v1.0.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants