Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Liechtenstein to country selection #8605

Merged
merged 1 commit into from
Nov 19, 2019
Merged

add Liechtenstein to country selection #8605

merged 1 commit into from
Nov 19, 2019

Conversation

Caahlo
Copy link
Contributor

@Caahlo Caahlo commented Nov 19, 2019

add Liechtenstein to country selection and document its municipalities as regions

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Add Liechtenstein to the documentation and to the country map drop-down menu
requires: apache-superset/superset-ui-plugins#263

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot (6)

TEST PLAN

  1. Go to the charts list
  2. Click on the "Birth in France by department in 2016" link
  3. under "Options" in the "Country Name" drop-down menu, select "Liechtenstein"

Expected

The borders of the cantons of Liechtenstein should appear in pale gray.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

add Liechtenstein to country selection and document its municipalities as regions
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #8605 into master will decrease coverage by 5.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8605      +/-   ##
==========================================
- Coverage   71.69%   65.69%      -6%     
==========================================
  Files         118      474     +356     
  Lines       12591    23583   +10992     
  Branches        0     2571    +2571     
==========================================
+ Hits         9027    15494    +6467     
- Misses       3564     7920    +4356     
- Partials        0      169     +169
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 42.18% <ø> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.46% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
superset/assets/src/components/EditableTitle.jsx 81.81% <0%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0%> (ø)
...t/assets/src/components/InfoTooltipWithTrigger.jsx 41.66% <0%> (ø)
.../src/dashboard/components/UndoRedoKeylisteners.jsx 9.52% <0%> (ø)
...ts/src/explore/components/ExploreActionButtons.jsx 100% <0%> (ø)
.../src/dashboard/components/FilterTooltipWrapper.jsx 100% <0%> (ø)
... and 347 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42aae8...73429a5. Read the comment docs.

@dpgaspar
Copy link
Member

Could you take the chance and update the doc on visualization.rst with the current declared select_country map?

@mistercrunch mistercrunch merged commit 07058c5 into apache:master Nov 19, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants