-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous style fixes spotted by landscape #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage decreased (-0.006%) to 81.488% when pulling 6c06fd901c771b96be0da2624738ca71b4f6139e on xrmx:landscape into aaef338 on airbnb:master. |
Coverage decreased (-0.006%) to 81.488% when pulling c02152a7210561b4270e65dc51b670277b7587b2 on xrmx:landscape into aaef338 on airbnb:master. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: remove single queryData from api * feat: migrate old plugins to queriesData api property * test: fix tests * test: fix tests * fix: fix storybook * lint: fix lint * refactor: fix CR notes * refactor: remove queryData from Chart Provider
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: remove single queryData from api * feat: migrate old plugins to queriesData api property * test: fix tests * test: fix tests * fix: fix storybook * lint: fix lint * refactor: fix CR notes * refactor: remove queryData from Chart Provider
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: remove single queryData from api * feat: migrate old plugins to queriesData api property * test: fix tests * test: fix tests * fix: fix storybook * lint: fix lint * refactor: fix CR notes * refactor: remove queryData from Chart Provider
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: remove single queryData from api * feat: migrate old plugins to queriesData api property * test: fix tests * test: fix tests * fix: fix storybook * lint: fix lint * refactor: fix CR notes * refactor: remove queryData from Chart Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.