pass the standalone request arg in the /caravel/slices/<slice_id>/ endpoint redirect
#876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris/support-standalone-arg-in-slice-id-endpoint
branch
from
dae508e to
6808aed
Compare
|
how can I fix the coveralls blocker? :( .02% doesn't seem problmatic) |
| (slc.slice_name, 'json_endpoint', slc.viz.json_endpoint), | ||
| (slc.slice_name, 'csv_endpoint', slc.viz.csv_endpoint), | ||
| (slc.slice_name, 'slice_id', |
There was a problem hiding this comment.
no need to test these 3 endpoints for all slices, let's pick one and write another unit test that tests using assertRedirects
remove unused import.
…te standalone redirect logic for Javascript 'false' instead of Python False
williaster
force-pushed
the
chris/support-standalone-arg-in-slice-id-endpoint
branch
from
6808aed to
77f2593
Compare
|
@mistercrunch I tried messing with the Also updated the |
|
Nice! |
mistercrunch
deleted the
chris/support-standalone-arg-in-slice-id-endpoint
branch
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave some context in slack, but this will be useful for us to auto-generate standalone viz's from a slice's
id. This endpoint currently re-directs to a slice's url, but ignores all arguments passed to it.@mistercrunch