Histogram #888

shkr · 2016-08-06T16:17:32Z

I have implemented a Histogram chart using design from http://bl.ocks.org/mbostock/1933560.
It extends BaseViz. It draws a histogram using d3.layout.histogram method after querying a given numeric column from the db. It changes color for different bar lengths in the histogram. It takes as input the no of bins for the histogram.

(Updated Thumbnail!)

The css and js file use the histogram code from https://bl.ocks.org/mbostock/3048450. THe viz.py extends from BaseViz to create chart data only for one histogram

The new css has been used from the d3 chart http://bl.ocks.org/mbostock/1933560

…gram

shkr · 2016-08-06T16:18:32Z

In response to Issue #714 posted and commented on earlier

coveralls · 2016-08-06T16:21:35Z

Coverage decreased (-0.7%) to 80.794% when pulling be55235e2e05630391cd4a6ee65d42154a9d1cf6 on shkr:histogram into 7c810db on airbnb:master.

coveralls · 2016-08-07T08:02:46Z

Coverage decreased (-0.6%) to 80.842% when pulling 65f88bdd2edd2b4ed8a9c6793a2e10dea6782628 on shkr:histogram into 7c810db on airbnb:master.

xrmx · 2016-08-07T08:55:43Z

caravel/viz.py

@@ -7,7 +7,6 @@
 from __future__ import division
 from __future__ import print_function
 from __future__ import unicode_literals
-


unrelated change

coveralls · 2016-08-07T18:17:28Z

Coverage decreased (-0.8%) to 80.724% when pulling 04e7eac8c4426e1c47e09f7cda91eabb7045f4fb on shkr:histogram into 7c810db on airbnb:master.

coveralls · 2016-08-07T18:17:28Z

Coverage decreased (-0.6%) to 80.842% when pulling 04e7eac8c4426e1c47e09f7cda91eabb7045f4fb on shkr:histogram into 7c810db on airbnb:master.

coveralls · 2016-08-08T01:14:50Z

Coverage decreased (-0.6%) to 80.842% when pulling 1ffd4e789b56d35af7ad5d711b50cf7ddd2c4c16 on shkr:histogram into 7c810db on airbnb:master.

coveralls · 2016-08-08T02:53:58Z

Coverage decreased (-0.5%) to 80.962% when pulling 0c0f146038de324be26fffd860b015dba0d30e51 on shkr:histogram into 7c810db on airbnb:master.

It takes as input no of bins. The histogram cycles through a set of colors for different lengths of the bar. It places a y axis coordinate on top or on the upper end of the bar whichever is suitable.

coveralls · 2016-08-08T18:05:15Z

Coverage decreased (-0.8%) to 80.704% when pulling 57461ae on shkr:histogram into cb23362 on airbnb:master.

coveralls · 2016-08-08T18:12:16Z

Coverage decreased (-0.5%) to 80.95% when pulling 57461ae on shkr:histogram into cb23362 on airbnb:master.

coveralls · 2016-08-08T18:21:51Z

Coverage decreased (-0.5%) to 80.95% when pulling 57461ae on shkr:histogram into cb23362 on airbnb:master.

shkr · 2016-08-08T18:51:02Z

@xrmx i have fixed the issues you posted

ascott · 2016-08-08T19:15:36Z

caravel/assets/visualizations/histogram.css

@@ -0,0 +1,24 @@
+.bars rect {}


unused style rule, let's delete this

coveralls · 2016-08-09T02:31:28Z

Coverage decreased (-0.5%) to 80.95% when pulling 6f6bec3a10ba1f73dc920c80978929db7ff4d268 on shkr:histogram into b0a1f07 on airbnb:master.

coveralls · 2016-08-09T02:58:19Z

Coverage decreased (-0.5%) to 80.95% when pulling c27c4e9bf572061c15a8faef5b533980063b3646 on shkr:histogram into b0a1f07 on airbnb:master.

coveralls · 2016-08-09T13:48:50Z

Coverage decreased (-0.5%) to 80.95% when pulling 017732ecca8501e52a6ae21a1e727198ea32340c on shkr:histogram into b0a1f07 on airbnb:master.

coveralls · 2016-08-09T13:48:50Z

Coverage decreased (-0.5%) to 80.95% when pulling 017732ecca8501e52a6ae21a1e727198ea32340c on shkr:histogram into b0a1f07 on airbnb:master.

coveralls · 2016-08-09T13:48:50Z

Coverage decreased (-0.5%) to 80.95% when pulling 017732ecca8501e52a6ae21a1e727198ea32340c on shkr:histogram into b0a1f07 on airbnb:master.

coveralls · 2016-08-09T13:55:44Z

Coverage decreased (-0.5%) to 80.95% when pulling 017732ecca8501e52a6ae21a1e727198ea32340c on shkr:histogram into b0a1f07 on airbnb:master.

shkr · 2016-08-09T23:18:40Z

@mistercrunch I checked out the details for the code-quality all the changes recommended except 1 PEP302 violation, are out of scope for this PR

xrmx · 2016-08-10T12:09:37Z

caravel/viz.py

@@ -1200,6 +1200,78 @@ def get_data(self):
        df.columns = ['x', 'y']
        return df.to_dict(orient="records")



one more empty line here

shkr · 2016-08-10T16:16:57Z

@xrmx Changes made as recommended

xrmx · 2016-08-10T16:17:47Z

@shkr thanks, python side looks good to me!

coveralls · 2016-08-10T16:31:53Z

Coverage decreased (-0.4%) to 81.002% when pulling 1f52595 on shkr:histogram into baf22c3 on airbnb:master.

coveralls · 2016-08-10T16:36:22Z

Coverage decreased (-0.4%) to 81.002% when pulling 1f52595 on shkr:histogram into baf22c3 on airbnb:master.

mistercrunch · 2016-08-10T22:04:15Z

LGTM mergin'

ascott · 2016-08-11T00:46:26Z

nice work, thx @shkr!

shkr added 8 commits July 26, 2016 09:50

Add Histogram as a visualization

47298c8

The css and js file use the histogram code from https://bl.ocks.org/mbostock/3048450. THe viz.py extends from BaseViz to create chart data only for one histogram

merge with airbnb/master

3d72075

using d3.layout.histogram

49d1c18

CSS updated

bed406f

The new css has been used from the d3 chart http://bl.ocks.org/mbostock/1933560

bars are visible

5be399b

added semicolons

a2ec275

Merge branch 'master' of https://github.com/airbnb/caravel into histo…

7e963df

…gram

Merge remote-tracking branch 'origin/master' into histogram

348acc1

xrmx reviewed Aug 7, 2016
View reviewed changes

shkr force-pushed the histogram branch from 0c0f146 to 849a630 Compare August 8, 2016 17:36

histogram from http://bl.ocks.org/mbostock/1933560

57461ae

It takes as input no of bins. The histogram cycles through a set of colors for different lengths of the bar. It places a y axis coordinate on top or on the upper end of the bar whichever is suitable.

shkr force-pushed the histogram branch from 5a2efb9 to 57461ae Compare August 8, 2016 17:43

ascott reviewed Aug 8, 2016
View reviewed changes

caravel/assets/visualizations/histogram.css

@@ -0,0 +1,24 @@

.bars rect {}

Copy link

ascott Aug 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused style rule, let's delete this

shkr force-pushed the histogram branch from 6f6bec3 to c27c4e9 Compare August 9, 2016 02:53

shkr force-pushed the histogram branch 2 times, most recently from 49fad96 to 017732e Compare August 9, 2016 13:42

xrmx reviewed Aug 10, 2016
View reviewed changes

update style changes

1f52595

shkr force-pushed the histogram branch from 1238637 to 1f52595 Compare August 10, 2016 16:16

xrmx mentioned this pull request Aug 10, 2016

Refactor around how visualizations/*.js are required #913

Merged

mistercrunch merged commit 15ee6d8 into apache:master Aug 10, 2016

ascott mentioned this pull request Aug 15, 2016

Histogram #714

Closed

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Histogram #888

Histogram #888

shkr commented Aug 6, 2016 •

edited

Loading

shkr commented Aug 6, 2016 •

edited

Loading

coveralls commented Aug 6, 2016 •

edited

Loading

coveralls commented Aug 7, 2016 •

edited

Loading

xrmx Aug 7, 2016

coveralls commented Aug 7, 2016

coveralls commented Aug 7, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

shkr commented Aug 8, 2016

ascott Aug 8, 2016

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016

coveralls commented Aug 9, 2016

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

shkr commented Aug 9, 2016

xrmx Aug 10, 2016

shkr commented Aug 10, 2016

xrmx commented Aug 10, 2016

coveralls commented Aug 10, 2016 •

edited

Loading

coveralls commented Aug 10, 2016 •

edited

Loading

mistercrunch commented Aug 10, 2016

ascott commented Aug 11, 2016

		@@ -1200,6 +1200,78 @@ def get_data(self):
		df.columns = ['x', 'y']
		return df.to_dict(orient="records")

Histogram #888

Histogram #888

Conversation

shkr commented Aug 6, 2016 • edited Loading

shkr commented Aug 6, 2016 • edited Loading

coveralls commented Aug 6, 2016 • edited Loading

coveralls commented Aug 7, 2016 • edited Loading

xrmx Aug 7, 2016

Choose a reason for hiding this comment

coveralls commented Aug 7, 2016

coveralls commented Aug 7, 2016 • edited Loading

coveralls commented Aug 8, 2016 • edited Loading

coveralls commented Aug 8, 2016 • edited Loading

coveralls commented Aug 8, 2016 • edited Loading

coveralls commented Aug 8, 2016 • edited Loading

coveralls commented Aug 8, 2016 • edited Loading

shkr commented Aug 8, 2016

ascott Aug 8, 2016

Choose a reason for hiding this comment

coveralls commented Aug 9, 2016 • edited Loading

coveralls commented Aug 9, 2016 • edited Loading

coveralls commented Aug 9, 2016

coveralls commented Aug 9, 2016

coveralls commented Aug 9, 2016 • edited Loading

coveralls commented Aug 9, 2016 • edited Loading

shkr commented Aug 9, 2016

xrmx Aug 10, 2016

Choose a reason for hiding this comment

shkr commented Aug 10, 2016

xrmx commented Aug 10, 2016

coveralls commented Aug 10, 2016 • edited Loading

coveralls commented Aug 10, 2016 • edited Loading

mistercrunch commented Aug 10, 2016

ascott commented Aug 11, 2016

shkr commented Aug 6, 2016 •

edited

Loading

shkr commented Aug 6, 2016 •

edited

Loading

coveralls commented Aug 6, 2016 •

edited

Loading

coveralls commented Aug 7, 2016 •

edited

Loading

coveralls commented Aug 7, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 8, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 9, 2016 •

edited

Loading

coveralls commented Aug 10, 2016 •

edited

Loading

coveralls commented Aug 10, 2016 •

edited

Loading