Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Disable FAB's permission and view menus views #9133

Merged
merged 5 commits into from
Feb 25, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 13, 2020

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Disable FAB's permission view and views view from the security menu. It's not considered very useful and reduces the number of view classes and endpoints

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #9133 into master will increase coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9133      +/-   ##
==========================================
+ Coverage   59.08%   59.16%   +0.08%     
==========================================
  Files         372      372              
  Lines       11926    11935       +9     
  Branches     2920     2927       +7     
==========================================
+ Hits         7046     7061      +15     
+ Misses       4698     4694       -4     
+ Partials      182      180       -2
Impacted Files Coverage Δ
...frontend/src/dashboard/reducers/getInitialState.js 0% <ø> (ø) ⬆️
superset-frontend/src/featureFlags.ts 91.66% <100%> (+0.75%) ⬆️
...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx 93.54% <80%> (-6.46%) ⬇️
superset-frontend/src/SqlLab/components/Link.tsx 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b310c...2e0b238. Read the comment docs.

@dpgaspar dpgaspar mentioned this pull request Feb 19, 2020
12 tasks
@dpgaspar dpgaspar marked this pull request as ready for review February 19, 2020 13:37
@dpgaspar dpgaspar requested a review from villebro February 20, 2020 09:00
@dpgaspar dpgaspar merged commit 23fc9a7 into apache:master Feb 25, 2020
@dpgaspar dpgaspar deleted the fix/viewmenu-permissions-disable branch February 25, 2020 00:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants