Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webpack] set up proper dev/prod environment #916

Merged
merged 1 commit into from
Aug 10, 2016
Merged

[webpack] set up proper dev/prod environment #916

merged 1 commit into from
Aug 10, 2016

Conversation

mistercrunch
Copy link
Member

process.env.NODE_ENV === 'production' is now possible in our js code. I'll use that to switch off the devTools in SQL Lab.

also React looks for this as well and will make a more efficient prod build going forward

@ascott @williaster

@coveralls
Copy link

coveralls commented Aug 10, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 81.405% when pulling 95664e5 on mistercrunch:dev_prod_setup into baf22c3 on airbnb:master.

@ascott
Copy link

ascott commented Aug 10, 2016

LGTM

@mistercrunch mistercrunch merged commit 08d6825 into apache:master Aug 10, 2016
@mistercrunch mistercrunch deleted the dev_prod_setup branch August 11, 2016 05:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @coveralls @ascott