[datasets] new, listview (react) #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
changed the title
nytai
force-pushed
the
tai/datasets-listivew
branch
from
c81ed53 to
b78a771
Compare
nytai
force-pushed
the
tai/datasets-listivew
branch
from
b78a771 to
abfd113
Compare
Codecov Report
@@ Coverage Diff @@
## master #9197 +/- ##
==========================================
+ Coverage 58.90% 59.10% +0.19%
==========================================
Files 373 374 +1
Lines 12026 12159 +133
Branches 2953 2982 +29
==========================================
+ Hits 7084 7186 +102
- Misses 4763 4794 +31
Partials 179 179
Continue to review full report at Codecov.
|
nytai
changed the title
nytai
force-pushed
the
tai/datasets-listivew
branch
from
e0d01af to
487abac
Compare
mistercrunch
approved these changes
Mar 11, 2020
|
When playing around with this, I get the following error with the following filters:
|
|
@villebro Thanks for catching that, I also found that my implementation of the database filter was incorrect. Both issues have been addressed. I've also added an exception which should help catch incorrect filter config moving forward. |
nytai
force-pushed
the
tai/datasets-listivew
branch
from
fe5d676 to
e701b21
Compare
nytai
force-pushed
the
tai/datasets-listivew
branch
from
e701b21 to
5d70c25
Compare
suddjian
reviewed
Mar 12, 2020
|
|
||
| handleDashboardDelete = ({ id, table_name: tableName }: Dataset) => | ||
| SupersetClient.delete({ | ||
| endpoint: `/api/v1/dashboard/${id}`, |
There was a problem hiding this comment.
I think you want a different endpoint here
villebro
approved these changes
Mar 12, 2020
nytai
changed the title
|
I just realized this change will remove the create button for datasets(tables). For Charts and Dashboards there was the |
|
Added a
|
nytai
force-pushed
the
tai/datasets-listivew
branch
from
9011584 to
22c68ea
Compare
nytai
changed the title
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Adds a new react listview to tables (soon to be renamed to datasets).
similar to #8845 and #8999
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ENABLE_REACT_CRUD_VIEWS) provides the same functionality as previous MVC crud viewsENABLE_REACT_CRUD_VIEWSADDITIONAL INFORMATION
REVIEWERS