Fixing ACE editor font jank (again?!) #9264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Fixes #9253
Playing whack-a-mole with a font width/tracking issue in ACE editor(s). Tried to fix it in Safari, which seemed to work, but somehow now causes issue in Chrome. Undoing the fix, with a net delta of a new typeface, SEEMS to me, to work in both Chrome AND Safari, but I feel like I could use a sanity check from @etr2460 or anyone else.
Also of note,
react-ace
is on v5 in Superset, where they're on v8. I tried upgrading, and ran into all sorts of upgrade woes. It DID seem to solve solve this font width issue, however. I'll try to make an upgrade somewhere between v6 and v8 on a separate PR, so heads up about that, and speak up with any experience/warnings/objections if you have them.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Chrome:
![chrome](https://user-images.githubusercontent.com/812905/76239602-1542d180-61ef-11ea-8648-944a68dede6e.gif)
Safari:
![safari](https://user-images.githubusercontent.com/812905/76239826-75397800-61ef-11ea-8ea7-73bb35e3380c.gif)
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@etr2460