fix: add connection testing params for snowflake #9272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
When connecting to a Snowflake database, the "Test Connection" button reports "Seems OK!", even if the user does not have proper rights to access the relevant database, schema, role or warehouse. This is problematic, because the connector introduces irregular behavior if proper authorization is missing, for instance returning duplicated schema names during calls to
inspector.get_schema_names()
. This PR introduces a methodBaseEngineSpec.mutate_db_for_connection_test
which can be overridden by a db spec to introduce connection validation, and implements the mostly undocumentedvalidate_default_parameters
flag (disabled by default, probably due to performance reasons) for Snowflake that validates the connection params when pressing "Test Connection".BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS