Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requirements] Bumping Celery #9277

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

john-bodley
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR bumps the version of celery (and indirectly kombu) which contain new features for heartbeat and keep alive as we've been seeing errors with Redis,

redis.exceptions.ConnectionError: Error while reading from socket: ('Connection closed by server.',)

Note I also needed to bump pip-tools to work with the latest version of pip (which is installed/updated during Travis CI).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @ktmud @villebro

@mistercrunch
Copy link
Member

celery

@john-bodley john-bodley force-pushed the john-bodley--bump-celery branch from 78a0169 to 618d95f Compare March 11, 2020 04:25
@codecov-io
Copy link

Codecov Report

Merging #9277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9277   +/-   ##
======================================
  Coverage    58.9%   58.9%           
======================================
  Files         373     373           
  Lines       12026   12026           
  Branches     2953    2953           
======================================
  Hits         7084    7084           
  Misses       4763    4763           
  Partials      179     179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724b8a3...618d95f. Read the comment docs.

@john-bodley john-bodley changed the title [requirements] Bumpy Celery [requirements] Bumping Celery Mar 11, 2020
@john-bodley john-bodley merged commit c0f0d45 into apache:master Mar 11, 2020
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Mar 18, 2020
etr2460 pushed a commit to etr2460/incubator-superset that referenced this pull request Mar 18, 2020
etr2460 pushed a commit that referenced this pull request Mar 18, 2020
* Revert "[requirements] Bumpy Celery (#9277)"

This reverts commit c0f0d45.

* Update requirements.txt
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants