-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard][api] Fix, PUT publish/draft to not clean slug and owners #9279
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9279 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
=======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified slightly?
We're seeing an issue and it seems related to this change, but I'd like to verify. So the behavior we're seeing is:
Would this be fixed after we get this change? |
Gengle ping, can @dpgaspar or anyone else chime in? |
UPDATE: this issue went away when we upgraded to version 0.36 |
CATEGORY
SUMMARY
Fix bug on the dashboard API, "Draft" Button Clears Slug and Owners from Dashboard.
Note: We are planning to refactor this soon to comply to SIP-35
TEST PLAN
Create a new dashboard with a slug and several owners, then publish the dashboard using the dashboard view itself. Verify that slug and owner do not get cleaned
ADDITIONAL INFORMATION
REVIEWERS