fix: adhoc filter 'equals' doesn't let you save #9652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9652 +/- ##
=======================================
Coverage 70.74% 70.74%
=======================================
Files 585 585
Lines 30429 30429
Branches 3115 3114 -1
=======================================
+ Hits 21526 21527 +1
+ Misses 8789 8788 -1
Partials 114 114
Continue to review full report at Codecov.
|
mistercrunch
force-pushed
the
fix_adhoc_filter_equals_bug
branch
2 times, most recently
from
10b4e99 to
bfb14f2
Compare
mistercrunch
commented
Apr 26, 2020
mistercrunch
force-pushed
the
fix_adhoc_filter_equals_bug
branch
from
bfb14f2 to
b4b73a1
Compare
mistercrunch
force-pushed
the
fix_adhoc_filter_equals_bug
branch
2 times, most recently
from
8b66de2 to
07255fc
Compare
When altering a filter, when using `equals` or `does not equals`, the save button is disabled even when it should be enalbed.
mistercrunch
force-pushed
the
fix_adhoc_filter_equals_bug
branch
from
07255fc to
9a06251
Compare
mistercrunch
commented
May 6, 2020
| @@ -45,7 +45,7 @@ combine_as_imports = true | |||
| include_trailing_comma = true | |||
| line_length = 88 | |||
| known_first_party = superset | |||
| known_third_party =alembic,apispec,backoff,bleach,celery,click,colorama,contextlib2,croniter,cryptography,dataclasses,dateutil,flask,flask_appbuilder,flask_babel,flask_caching,flask_compress,flask_login,flask_migrate,flask_sqlalchemy,flask_talisman,flask_testing,flask_wtf,geohash,geopy,humanize,isodate,jinja2,markdown,markupsafe,marshmallow,msgpack,numpy,pandas,parsedatetime,pathlib2,polyline,prison,pyarrow,pyhive,pytz,retry,selenium,setuptools,simplejson,sphinx_rtd_theme,sqlalchemy,sqlalchemy_utils,sqlparse,werkzeug,wtforms,wtforms_json,yaml | |||
| known_third_party =alembic,apispec,backoff,bleach,celery,click,colorama,contextlib2,croniter,cryptography,dateutil,flask,flask_appbuilder,flask_babel,flask_caching,flask_compress,flask_login,flask_migrate,flask_sqlalchemy,flask_talisman,flask_testing,flask_wtf,geohash,geopy,humanize,isodate,jinja2,markdown,markupsafe,marshmallow,msgpack,numpy,pandas,parsedatetime,pathlib2,polyline,prison,pyarrow,pyhive,pytz,retry,selenium,setuptools,simplejson,sphinx_rtd_theme,sqlalchemy,sqlalchemy_utils,sqlparse,werkzeug,wtforms,wtforms_json,yaml | |||
There was a problem hiding this comment.
pre-commit hooks are doing this...
mistercrunch
commented
May 6, 2020
| @@ -15,11 +15,11 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| import logging | |||
| from dataclasses import dataclass | |||
|
Addressed comments, @villebro or anyone, can a get a formal stamp? Also feel free to merge. |
villebro
approved these changes
May 6, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
Applies to
equalsanddoes not equal