Revert "FilterBox,BigNumber,WorldMap: Handle empty results" #9755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 865a909.
|
Attach a time-range filter: |
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 6, 2020
…)" (apache#9755) This reverts commit 865a909. (cherry picked from commit 4b6681b)
|
ah snap really sorry, will try to re-work the PR! :( |
12 tasks
bkyryliuk
pushed a commit
to bkyryliuk/incubator-superset
that referenced
this pull request
May 13, 2020
…)" (apache#9755) This reverts commit 865a909.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9671
Unfortunately this breaks filterboxes with only a time range filter. I'm reverting for now, but it should be pretty easy to fix and re-PR out.
cc: @villebro @elukey @graceguo-supercat