test(frontend): use absolute path for src imports

[ktmud]

CATEGORY

• Refactor
• Build / Development Environment

SUMMARY

This changes all JS imports in specs to use absolute path, which makes the code a little bit easier to read and shall make rearranging the test files easier.

Added a jsconfig.json for VS Code so that intellisense can still work.

Also upgraded prettier to fix lint.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Make sure CI passes and other IDEs also have no problem using JS features.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@kristw @rusackas @villebro

[ktmud]

prettier changed the default behavior for arrowParent. We revert it back to the old behavior.

[kristw]

There seems to be another change to space between function and parentheses.

function() {} vs function () {}

I do not have strong preference in terms of styling but perhaps we can use the original to reduce amount of changes.

This is the settings from @superset-ui

{
  "arrowParens": "avoid",
  "bracketSpacing": true,
  "jsxBracketSameLine": false,
  "printWidth": 100,
  "proseWrap": "always",
  "requirePragma": false,
  "semi": true,
  "singleQuote": true,
  "tabWidth": 2,
  "trailingComma": "all",
  "useTabs": false
};

[ktmud]

https://prettier.io/blog/2020/03/21/2.0.0.html#always-add-a-space-after-the-function-keyword-3903httpsgithubcomprettierprettierpull3903-by-j-f1httpsgithubcomj-f1-josephfrazierhttpsgithubcomjosephfrazier-sosukesuzukihttpsgithubcomsosukesuzuki-thorn0httpsgithubcomthorn0-7516httpsgithubcomprettierprettierpull7516-by-bakkothttpsgithubcombakkot

It seems Prettier folks decided this is somehow the preferred style and didn't add an option to turn it off.

[kristw]

ic. If no strong objection from others I am good with this. I'll approve but wait for others to have a chance to see the PR.

[rusackas]

I prefer without the space, but if there's no way to turn it off, it won't break my heart.

[rusackas]

I just read through some of the threads on that feature, and now I'm glad I don't work on that project. Yeesh!

[ktmud]

Can we merge this then? 😄

[codecov-io]

Codecov Report

Merging #9761 into master will decrease coverage by 0.01%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master    #9761      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.02%     
==========================================
  Files         586      586              
  Lines       30445    30444       -1     
  Branches     3121     3120       -1     
==========================================
- Hits        21559    21555       -4     
- Misses       8772     8775       +3     
  Partials      114      114              

Flag	Coverage Δ
#cypress	53.65% <42.10%> (-0.08%)	⬇️
#javascript	59.06% <75.86%> (-0.01%)	⬇️
#python	70.93% <ø> (ø)

Impacted Files	Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx	65.90% <ø> (-6.82%)	⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx	55.12% <ø> (ø)
superset-frontend/src/explore/AdhocFilter.js	97.26% <ø> (ø)
...set-frontend/src/explore/actions/exploreActions.js	44.77% <50.00%> (ø)
.../explore/components/controls/DateFilterControl.jsx	56.36% <75.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	66.81% <85.71%> (ø)
superset-frontend/src/SqlLab/components/App.jsx	77.77% <100.00%> (ø)
...set-frontend/src/SqlLab/components/QuerySearch.jsx	57.54% <100.00%> (ø)
...rset-frontend/src/SqlLab/components/QueryTable.jsx	59.25% <100.00%> (ø)
superset-frontend/src/chart/chartAction.js	59.50% <100.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b430ea...93aeede. Read the comment docs.

[rusackas]

Jeez... I keep spending forever looking at these things, and then when I'm done, I look up and see Merged 🤣Again, this looks great, and thanks.