Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][DOC] Update header links and image files #1072

Closed
wants to merge 1 commit into from
Closed

[MINOR][DOC] Update header links and image files #1072

wants to merge 1 commit into from

Conversation

j143
Copy link
Contributor

@j143 j143 commented Sep 29, 2020 •
edited
Loading

What this PR do?

  • Update header links.
  • Add convolution image files

TL;DR:

image

@Baunsgaard
Copy link
Contributor

Baunsgaard commented Sep 29, 2020 •
edited
Loading

Hi @j143, this does not work once you go into any sub-page,
since each of the links refer to relative paths from where you are.

This means that from the main page it links correctly, from lets say DML Language Reference it does not.

Baunsgaard
Baunsgaard reviewed Sep 29, 2020
View reviewed changes
docs/_includes/header.html
<!--
<li><a href="site/engine-dev-guide.html">Engine Developer Guide</a></li>
<li><a href="site/troubleshooting-guide.html">Troubleshooting Guide</a></li>
<li><a href="site/release-process.html">Release Process</a></li> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I would remove these uncommented links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to remove these.

These are the document pages necessary to be provided in the future. 😃

@j143
Copy link
Contributor Author

j143 commented Sep 29, 2020

this does not work once you go into any sub-page,
since each of the links refer to relative paths from where you are.

Is it possible to correct the links based on how you intend the website to deploy. Can you do that? Thanks.

cc @Baunsgaard

Baunsgaard pushed a commit to Baunsgaard/systemds that referenced this pull request Sep 30, 2020
@j143 @Baunsgaard
[MINOR][DOC] Update header links and image files
4bcf801 
fix relative path when inside site

closes apache#1072
@Baunsgaard
Copy link
Contributor

thanks for the PR i have merged it now. I did some minor modifications such as adding an option to go back to the main overview page..

@j143 j143 deleted the doc-navigation branch October 8, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baunsgaard Baunsgaard Baunsgaard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j143 @Baunsgaard