Enhance TFramedTransport performance for nodejs

[wujjpp]

Enhance TFramedTransport performance for nodejs

1. use array.push instread of Array.concat, array.push is more effective than Array.concat, see benchmark results
2. reduce data copy action for improving performance.

const Benchmark = require('benchmark');

const buffer = Buffer.alloc(1024)
buffer.fill('A')
const loop = 1024;

const suite = new Benchmark.Suite()

suite
  .add('Buffer.concat', function () {
    let target = Buffer.alloc(0)
    for(let i = 0; i < loop; ++i){
      target = Buffer.concat([target, buffer], target.length + buffer.length)
    }
  })
  .add('Array.push', function () {
    const target = []
    for(let i = 0; i < loop; ++i){
      for(let j = 0; j < buffer.length; ++j){
        target.push(buffer[i])
      }
    }
  })
  .on('cycle', function(event) {
    console.log(String(event.target));
  })
  .on('complete', function() {
    console.log('Fastest is ' + this.filter('fastest').map('name'));
    // console.log(this)
  })
  .run({ async: true })

results:
Buffer.concat x 6.72 ops/sec ±21.71% (24 runs sampled)
Array.push x 47.35 ops/sec ±1.56% (61 runs sampled)
Fastest is Array.push

[Jens-G]

What happened to "data"?

[wujjpp]

Combined to residual, then if condition matched, splice(4) and splice(frameSize)

[Jens-G]

Nope, still says "data".

return function(data) {

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.