ZOOKEEPER-4699: Fix hostname use-after-free in the C client

Reviewers: kezhuw, ztzg Author: fanyang89 Closes #2138 from fanyang89/fix-c-client-hostname-uaf (cherry picked from commit e72f80a)
apache · Oct 28, 2024 · c18cd9e · c18cd9e
1 parent f5ed8aa
commit c18cd9e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/zookeeper-client/zookeeper-client-c/src/zookeeper.c b/zookeeper-client/zookeeper-client-c/src/zookeeper.c
@@ -2558,8 +2558,9 @@ int zookeeper_interest(zhandle_t *zh, socket_t *fd, int *interest,
             *tv = get_timeval(zh->recv_timeout/60);
             zh->delay = 0;
 
-            LOG_WARN(LOGCALLBACK(zh), "Delaying connection after exhaustively trying all servers [%s]",
-                     zh->hostname);
+            lock_reconfig(zh);
+            LOG_WARN(LOGCALLBACK(zh), "Delaying connection after exhaustively trying all servers [%s]", zh->hostname);
+            unlock_reconfig(zh);
         } else {
             if (addr_rw_server) {
                 zh->addr_cur = *addr_rw_server;