Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zookeeper-c-client): include winports.h for WIN32 systems #2044

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidVujic
Copy link

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 8, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Contributor

@ztzg ztzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I haven't had a chance to test the change).

@DavidVujic
Copy link
Author

I have some trouble running tests locally, but think that the previous workflow failures were caused by a typo (accidentally missed an "end if"). Can you run the workflows again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants