Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] (Trivial) Update GitHub Actions #2216

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

ctubbsii
Copy link
Member

  • Use v4 actions
  • Use language-specific setup-java's cache instead of general purpose actions/cache

* Use v4 actions
* Use language-specific setup-java's cache instead of general purpose
  actions/cache
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctubbsii . lgtm, but I'd like to see what's @eolivelli 's opinion.

@ctubbsii
Copy link
Member Author

Thanks @ctubbsii . lgtm, but I'd like to see what's @eolivelli 's opinion.

I don't think this one requires much review... it's a pretty trivial change... but more importantly, it's a required change. Some of these v3 actions will stop working soon and ZK's builds will start breaking (actually, they won't run at all and will fail immediately while the yaml is being parsed). This specific PR is in response to INFRA's recent notice sent to projects who are still using v3 artifacts. Although only a few of the actions will be banned soon, the others will also eventually be banned, for being too old. In short: bumping the versions from v3 to v4 needs to be done. ZK doesn't have a choice here.

The only thing optional in this PR is the change to use setup-java's language-specific cache mechanism for Maven, rather than using the low-level actions/cache, but I think that change is also pretty obvious and trivial and is documented here. For context, I was the one who originally authored these files in d7ed7f3 and was the one who introduced the old caching mechanism in these files. I have already migrated my own projects to use this new method to cache build dependencies. It's a much simpler config to maintain, and works just as well.

@anmolnar anmolnar merged commit aba99cf into apache:master Nov 26, 2024
14 checks passed
asfgit pushed a commit that referenced this pull request Nov 26, 2024
Reviewers: anmolnar
Author: ctubbsii
Closes #2216 from ctubbsii/update-ga-v4

(cherry picked from commit aba99cf)
Signed-off-by: Andor Molnar <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 26, 2024
Reviewers: anmolnar
Author: ctubbsii
Closes #2216 from ctubbsii/update-ga-v4

(cherry picked from commit aba99cf)
Signed-off-by: Andor Molnar <[email protected]>
@anmolnar
Copy link
Contributor

Done. I merged to all maintained branches: master, branch-3.9 and branch-3.8
Thanks @ctubbsii !

@ctubbsii ctubbsii deleted the update-ga-v4 branch November 28, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants