forked from nfl/react-gpt
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React v17 support #32
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ac34fd7
update deps
stephensauceda 5b258e9
update radium to version supporting react 17
stephensauceda faf7870
add prepare script
stephensauceda cec18b3
remove prepare script
stephensauceda 939ee3d
findDOMNode is deprecated
stephensauceda 2312442
make peerDependencies more lenient
stephensauceda 9d0eec6
ref needs to be on different node
stephensauceda 799f43e
Reverting the version as i will do that in another step
andrew-sotiriou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,14 @@ | |
"bugs": { | ||
"url": "https://github.com/apartmenttherapy/react-gpt/issues" | ||
}, | ||
"files": ["*.md", "docs", "es", "src", "dist", "lib"], | ||
"files": [ | ||
"*.md", | ||
"docs", | ||
"es", | ||
"src", | ||
"dist", | ||
"lib" | ||
], | ||
"dependencies": { | ||
"deep-equal": "^1.0.1", | ||
"eventemitter3": "^2.0.2", | ||
|
@@ -78,10 +85,9 @@ | |
"prop-types": "^15.5.10", | ||
"querystring": "^0.2.0", | ||
"radium": "^0.25.1", | ||
"react": "^16.0.0", | ||
"react-addons-test-utils": "^15.0.1", | ||
"react-dom": "^16.0.0", | ||
"react-test-renderer": "^16.0.0", | ||
"react": "^17.0.2", | ||
"react-dom": "^17.0.2", | ||
"react-test-renderer": "^17.0.2", | ||
"rimraf": "^2.5.2", | ||
"serve-static": "^1.10.2", | ||
"sinon": "^1.17.2", | ||
|
@@ -92,29 +98,24 @@ | |
}, | ||
"peerDependencies": { | ||
"prop-types": "^15.5.10", | ||
"react": "^15.0.1 || ^16.0.0", | ||
"react-dom": "^15.0.1 || ^16.0.0" | ||
"react": "^15.0.1 || ^16.0.0 || ^17.0.2", | ||
"react-dom": "^15.0.1 || ^16.0.0 || ^17.0.2" | ||
}, | ||
"scripts": { | ||
"commit": "git-cz", | ||
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s", | ||
"build": "npm run clean && npm run compile", | ||
"build:es": "BABEL_ENV=es babel --copy-files ./src -d es", | ||
"build:umd": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier got a hold of some of this. The only relevant changes are the deps above. |
||
"NODE_ENV=development webpack src/index.js dist/react-gpt.js", | ||
"build:umd:min": | ||
"NODE_ENV=production webpack -p src/index.js dist/react-gpt.min.js", | ||
"build:umd": "NODE_ENV=development webpack src/index.js dist/react-gpt.js", | ||
"build:umd:min": "NODE_ENV=production webpack -p src/index.js dist/react-gpt.min.js", | ||
"bundlesize": "npm run build:umd:min && bundlesize", | ||
"clean": "rimraf lib coverage dist lib es", | ||
"compile": "babel src --out-dir lib", | ||
"examples": | ||
"webpack-dev-server --config examples/webpack.config.js --content-base examples/apps --inline", | ||
"examples": "webpack-dev-server --config examples/webpack.config.js --content-base examples/apps --inline", | ||
"lint": "eslint --fix src test examples", | ||
"start": | ||
"npm run build && env BABEL_ENV=examples node examples/server/index.js", | ||
"start": "npm run build && env BABEL_ENV=examples node examples/server/index.js", | ||
"pretest": "npm run build", | ||
"prepublish": | ||
"npm run build && npm run build:es && npm run build:umd && npm run build:umd:min", | ||
"prepublish": "npm run build && npm run build:es && npm run build:umd && npm run build:umd:min", | ||
"test": "npm run lint && karma start", | ||
"update-apilist": "node ./scripts/updateAPIList.js" | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you guys have already migrated to using
react-dom/test-utils
so this doesn't appear to be needed anymore