Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwriteRequestBaseUrl - overwrite value with path parameters excludes parameters #446

Merged

Conversation

bvigerzi
Copy link
Contributor

When the overwriteRequestBaseUrl has a path parameter it is not included in the overwrite. For example,

{{newUrl}}/subPath will result in a host of {{newUrl}} while subPath will be discarded. This change will include subPath at the start of the path array in the postman spec

@thim81
Copy link
Collaborator

thim81 commented Jan 14, 2023

@bvigerzi This PR looks ready for good.

I have only one remark, which would be the introduction of Lodash.
Is there an alternative for the Lodash function isEqual function, for comparing the array path items?

@thim81 thim81 requested a review from nicklloyd January 16, 2023 08:50
@nicklloyd
Copy link
Contributor

not fussed by the inclusion of lodash.

@thim81 thim81 merged commit edf62f9 into apideck-libraries:main Jan 16, 2023
@bvigerzi bvigerzi deleted the fix-overwrite-base-url-paths branch March 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants