Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overwriteRequestBody root should overwrite #524

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix: overwriteRequestBody root should overwrite #524

merged 1 commit into from
Oct 28, 2023

Conversation

jackdclark
Copy link
Contributor

overwriteRequestBody isn't taking the overwrite flag into account when overwriting the root (.). It's my understanding from the docs that the request body should only be merged when overwrite is false.

Fixes #480

@thim81
Copy link
Collaborator

thim81 commented Oct 28, 2023

hi @jackdclark

Thanks for another PR.
I'm doing some clean-up with the failing unit tests.
After that is done, your PR will be next on the list.

@thim81 thim81 merged commit 6baee25 into apideck-libraries:main Oct 28, 2023
3 of 4 checks passed
@thim81
Copy link
Collaborator

thim81 commented Oct 28, 2023

hi @jackdclark

Thank you for taking the time to fix this issue.
It is merged and will be part of the next Portman release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thim81 thim81 thim81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overwrite requestBody adds to request Body instead of replaces whole body
2 participants
@jackdclark @thim81