Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove memored; use third party lib #239

Merged
merged 2 commits into from
Jun 14, 2019
Merged

remove memored; use third party lib #239

merged 2 commits into from
Jun 14, 2019

Conversation

srinandan
Copy link
Contributor

No description provided.

@srinandan srinandan requested a review from theganyo June 7, 2019 16:44
Copy link
Collaborator

@theganyo theganyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you just moved these two libraries?

Copy link
Collaborator

@theganyo theganyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we duplicating this same library code in both microgateway and microgateway-plugins?

@srinandan
Copy link
Contributor Author

it should not be. microgateway-plugins should be referring to this code. i don't think there is a copy in plugins.

@theganyo
Copy link
Collaborator

theganyo commented Jun 7, 2019

Oh... you're right. But that's not good... microgateway-plugins doesn't rely on this package (and shouldn't). This should be split out into a package common between them if they both rely on it.

@theganyo theganyo merged commit d7c5627 into master Jun 14, 2019
@theganyo theganyo deleted the 134751883 branch June 14, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants