-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css does not respect Apigee Kickstart color scheming #397
Comments
@m-khan23 - Are you using kickstart ? If yes, we will move this over to kickstart queue and work it there. |
@m-khan23 can you explain what Drupal theme colors you are comparing the "try it now" colors? The reason is that SmartDocs OpenAPI spec renderer is created in Angular, which we are embedding into Drupal. I believe you are saying that the color scheme should match the default of the Kickstart theme and also be easily adjustable. Is that correct? |
Yes that is correct. In other words, out of the box, I would expect the theme to respect var(--ak-accent-color) and var(--ak-accent-color-light) - makes for a good experience. I made the following overrides (a bit wonky) but they get the job done: /* 12/18/19 --> Start of addition (Mohammad) */ .mat-toolbar.mat-primary { .mat-fab, .mat-flat-button, .mat-mini-fab, .mat-raised-button, .mat-fab.mat-accent, .mat-flat-button.mat-accent, .mat-mini-fab.mat-accent, .mat-raised-button.mat-accent { .mat-primary:disabled { /* 12/18/19 --> End of Addition */ |
Sorry, I just realized I wrote 'Drupal' instead of 'Apigee Kickstart'. |
Moving to Kickstart project so that we can create a CSS file with good comments in the Kickstart theme that takes care of this and can be a source of self documentation for users to know how to make other color changes to the SmartDocs embedded app. |
* [#397] Scaffolding for smartdocs CSS overrides. * [#397] Create a library to load smartdocs css with field. * [#397] Default smartdoc color sheet. * [#397] Replace hex values with variables. * [#397] Delete CodeMirror and other non-mat- styles. * [#397] Do not override greys. * [#397] Replace rgb values and remaining hex values with variables. * [#397] Change Execute button color and add code text style. * TW-18324759 Remove empty line.
* [#397] Scaffolding for smartdocs CSS overrides. * [#397] Create a library to load smartdocs css with field. * [#397] Default smartdoc color sheet. * [#397] Replace hex values with variables. * [#397] Delete CodeMirror and other non-mat- styles. * [#397] Do not override greys. * [#397] Replace rgb values and remaining hex values with variables. * [#397] Change Execute button color and add code text style. * [#400] Dependency updates from npm audit fix.
* [#397] Scaffolding for smartdocs CSS overrides. * [#397] Create a library to load smartdocs css with field. * [#397] Default smartdoc color sheet. * [#397] Replace hex values with variables. * [#397] Delete CodeMirror and other non-mat- styles. * [#397] Do not override greys. * [#397] Replace rgb values and remaining hex values with variables. * [#397] Change Execute button color and add code text style. * [#403] Upgrade better_exposed_filters from ^3.0@alpha to ^5.0. * [#403] CSS fixes to exposed filter. * [#403] Update patch for better_exposed_filters issue 3001967. Co-authored-by: Arlina Espinoza <[email protected]>
Try it now functionality comes with its own scheme of colors (pink - #f44336) going against the Drupal theme colors. There is no option to adjust this either. It should be 'color: var(--ak-accent-color)' or some variation of this
The text was updated successfully, but these errors were encountered: