Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css does not respect Apigee Kickstart color scheming #397

Closed
m-khan23 opened this issue Dec 19, 2019 · 5 comments · Fixed by #399
Closed

css does not respect Apigee Kickstart color scheming #397

m-khan23 opened this issue Dec 19, 2019 · 5 comments · Fixed by #399
Assignees
Milestone

Comments

@m-khan23
Copy link

Try it now functionality comes with its own scheme of colors (pink - #f44336) going against the Drupal theme colors. There is no option to adjust this either. It should be 'color: var(--ak-accent-color)' or some variation of this

@arunz6161
Copy link
Collaborator

@m-khan23 - Are you using kickstart ? If yes, we will move this over to kickstart queue and work it there.

@cnovak
Copy link
Collaborator

cnovak commented Jan 29, 2020

@m-khan23 can you explain what Drupal theme colors you are comparing the "try it now" colors? The reason is that SmartDocs OpenAPI spec renderer is created in Angular, which we are embedding into Drupal. I believe you are saying that the color scheme should match the default of the Kickstart theme and also be easily adjustable. Is that correct?

@m-khan23
Copy link
Author

Yes that is correct. In other words, out of the box, I would expect the theme to respect var(--ak-accent-color) and var(--ak-accent-color-light) - makes for a good experience.

I made the following overrides (a bit wonky) but they get the job done:

/* 12/18/19 --> Start of addition (Mohammad) */

.mat-toolbar.mat-primary {
background: #eaeaea !important;
color: white !important;
}

.mat-fab, .mat-flat-button, .mat-mini-fab, .mat-raised-button, .mat-fab.mat-accent, .mat-flat-button.mat-accent, .mat-mini-fab.mat-accent, .mat-raised-button.mat-accent {
background-color: var(--ak-accent-color) !important;
color: white !important;
}

.mat-primary:disabled {
background: rgba(0,0,0,.38) !important;
color: gray !important;
}

/* 12/18/19 --> End of Addition */

@m-khan23
Copy link
Author

Sorry, I just realized I wrote 'Drupal' instead of 'Apigee Kickstart'.

@m-khan23 m-khan23 changed the title css does not respect Drupal color scheming css does not respect Apigee Kickstart color scheming Jan 30, 2020
@cnovak
Copy link
Collaborator

cnovak commented Jul 21, 2020

Moving to Kickstart project so that we can create a CSS file with good comments in the Kickstart theme that takes care of this and can be a source of self documentation for users to know how to make other color changes to the SmartDocs embedded app.

@cnovak cnovak transferred this issue from apigee/apigee-api-catalog-drupal Jul 21, 2020
@arunz6161 arunz6161 added this to the 8.x-1.18 milestone Jul 21, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 29, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 30, 2020
zakiya pushed a commit to zakiya/apigee-devportal-kickstart-drupal that referenced this issue Jul 30, 2020
@arlina-espinoza arlina-espinoza linked a pull request Jul 31, 2020 that will close this issue
arlina-espinoza pushed a commit that referenced this issue Jul 31, 2020
* [#397] Scaffolding for smartdocs CSS overrides.

* [#397] Create a library to load smartdocs css with field.

* [#397] Default smartdoc color sheet.

* [#397] Replace hex values with variables.

* [#397] Delete CodeMirror and other non-mat- styles.

* [#397] Do not override greys.

* [#397] Replace rgb values and remaining hex values with variables.

* [#397] Change Execute button color and add code text style.

* TW-18324759 Remove empty line.
arlina-espinoza pushed a commit that referenced this issue Aug 11, 2020
* [#397] Scaffolding for smartdocs CSS overrides.

* [#397] Create a library to load smartdocs css with field.

* [#397] Default smartdoc color sheet.

* [#397] Replace hex values with variables.

* [#397] Delete CodeMirror and other non-mat- styles.

* [#397] Do not override greys.

* [#397] Replace rgb values and remaining hex values with variables.

* [#397] Change Execute button color and add code text style.

* [#400] Dependency updates from npm audit fix.
arlina-espinoza added a commit that referenced this issue Sep 1, 2020
* [#397] Scaffolding for smartdocs CSS overrides.

* [#397] Create a library to load smartdocs css with field.

* [#397] Default smartdoc color sheet.

* [#397] Replace hex values with variables.

* [#397] Delete CodeMirror and other non-mat- styles.

* [#397] Do not override greys.

* [#397] Replace rgb values and remaining hex values with variables.

* [#397] Change Execute button color and add code text style.

* [#403] Upgrade better_exposed_filters from ^3.0@alpha to ^5.0.

* [#403] CSS fixes to exposed filter.

* [#403] Update patch for better_exposed_filters issue 3001967.

Co-authored-by: Arlina Espinoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants