Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade better_exposed_filters #414

Merged
merged 13 commits into from
Sep 1, 2020
Merged

Conversation

zakiya
Copy link
Contributor

@zakiya zakiya commented Aug 19, 2020

This upgrades to the latest version of better_exposed_filters and makes minor styling fixes.
Note that there is a small bug in better_exposed_filters that makes the reset button visible at all times. There is an open issue for this on Drupal.org.

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Aug 19, 2020
@zakiya zakiya requested a review from arlina-espinoza August 19, 2020 23:18
@arlina-espinoza arlina-espinoza linked an issue Sep 1, 2020 that may be closed by this pull request
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates CLA has not been signed and removed cla: yes Indicates CLA has been signed labels Sep 1, 2020
@arlina-espinoza
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates CLA has been signed and removed cla: no Indicates CLA has not been signed labels Sep 1, 2020
Copy link
Contributor

@arlina-espinoza arlina-espinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, I just updated the patch to the one compatible with this version.

@arlina-espinoza arlina-espinoza merged commit ae22c6d into apigee:8.x-1.x Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better_exposed_filters module conflicting on composer upgrade
3 participants