Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#127] Starter kit and sub theming docs #267

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

jacine
Copy link
Contributor

@jacine jacine commented Sep 13, 2019

Fixes #127.

As mentioned in #127, the following issues need to be worked out before this is merged.

@googlebot googlebot added the cla: yes Indicates CLA has been signed label Sep 13, 2019
@jacine
Copy link
Contributor Author

jacine commented Sep 13, 2019

It's worth noting that you can't really test this ATM, as those 2 Radix issues (which @arshad has already started to work on) really are needed.

I have committed the kit here, verbatim, which would allow you to run the command, and get past the Drush subtheme generator expects the kit to be located in Radix: drush --include="web/themes/contrib/radix" radix:create "subtheme" --kit=https://github.com/jacine/radix-kit-apigee_custom/archive/master.zip

However, if you test, you will notice that not all of the configuration files are renamed properly, due to the other issue: Provide a means to rename other additional configuration files.

@shadcn
Copy link
Contributor

shadcn commented Oct 7, 2019

The two Radix issues are now completed and in the latest dev release.

https://www.drupal.org/project/radix/issues/3081166
https://www.drupal.org/project/radix/issues/3081150

I tested this PR and everything is working. I'm going to go ahead and merge this. I'll create a follow up PR to update Radix to the latest stable release.

Thanks @jacine

@shadcn shadcn marked this pull request as ready for review October 7, 2019 10:42
Copy link
Contributor

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved. Thanks @jacine

@shadcn shadcn merged commit 5422f13 into apigee:8.x-1.x Oct 7, 2019
@jacine jacine deleted the 127-subtheming branch October 7, 2019 13:06
@jacine
Copy link
Contributor Author

jacine commented Oct 7, 2019

Thank you @arshad! I just tested the Radix issues and they're both good to go. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create subtheme instructions/template
3 participants