First and Last Name fields can't be populated by cas_attributes module

[jemisonf]

Describe the bug
I'd like to be able to populate the "First Name" and "Last Name" fields for a user using CAS attribute tokens provided by the cas_attributes module. This is possible for "normal" fields like username/email, and "normal" custom fields -- I tested this out by adding a "Nickname" field that I was able to configure.

I think this is an issue related to how those fields are added to the user entity, but I have no idea how to approach this problem otherwise.

If this is the wrong repository for this issue, let me know and I can move it somewhere else.

To Reproduce
Steps to reproduce the behavior:

1. Create a new apigee kickstart site (this is how I encountered the issue)
2. Install and configure the drupal/cas module (I don't think you need a working CAS server to test this)
3. Enable the cas_attributes module
4. Navigate to /admin/config/people/cas/attributes -- the "User Field Mappings" > "Fields" section should only show the email and username fields, and not first name and last name

Expected behavior
I would expect the "Fields" section in step four to also show "First Name" and "Last Name".

Screenshots
Here's what the user fields mapping section looks like:

Additional context
This also causes an issue where users whose accounts are created via a CAS sign-in don't have a first name and last name configured by default, which can then cause issues on subsequent sign-ins. Previously, in our D7 portal, we were able to use cas_attributes to automatically populate these values, which made the process transparent to users.

Version Info
1.8.0

[varuntit101]

I am facing the similar issue, but with different module - Social Auth Google

On logging with google, email and username is updating, but not First Name and Last Name, this results in not creating a Developer in Edge as First name and Last Name are also mandatory fields.
Please refer the screenshot

Can we set default First Name and Last Name in Apigee Edge module, as It is not sure that third party login modules will set all default attributes.

[kscheirer]

@varuntit101 For social auth logins, you can use this https://github.com/kscheirer/Social-Auth-Map-Name to enable first name and last name field mapping. I wrote up some sparse instructions here: apigee/apigee-devportal-kickstart-drupal#238 (comment).

[kscheirer]

@jemisonf The problem is likely here in the cas_attributes module: https://git.drupalcode.org/project/cas_attributes/-/blob/8.x-1.x/src/Form/CasAttributesSettings.php#L131, though I havent tested that out. The fields that will be rendered must have a target bundle defined, and be of type 'string' or 'list_string', so I'm guessing one of those conditions is not true.

[varuntit101]

@kscheirer I tried using https://github.com/kscheirer/Social-Auth-Map-Name, this works absolutely fine with Social Auth Google, but It is failing with Social Auth GitHub, it is giving error on following code :-

$user->set('first_name', $userInfo->getFirstName());
$user->set('last_name', $userInfo->getLastName());

[jemisonf]

@kscheirer thanks, that's a good find! It looks like the first_name and last_name fields are defined here as string_textfield, so it makes perfect sense if that's causing the issue. Not sure if it makes more sense to change this module to address it or to make a PR to cas_attributes so they can handle more field types.

Either way, that gives me a way I can temporarily fix it right now to resolve the issue, which is great.

[jemisonf]

Follow-on to that: it looks like the issue isn't actually that first_name and last_name have the wrong type, it's this check:

if (!empty($definition->getTargetBundle())) {

Which is failing because first_name and last_name aren't part of a bundle. Taking this check out resolves the issue, but does cause some extra fields to show up, which might not be desirable behavior. It seems like a better fix would be to add the fields to a bundle when they're created, although I'm not sure what the best option for that is.

[arlina-espinoza]

@jemisonf I added a PR that would add the bundle to the first/last name fields. Not sure if any other module is needing this, but I don't see harm in adding it either.
PR: [#396] Add a target bundle to first and last name user fields.

[jemisonf]

@arlina-espinoza that looks great, thank you! I'll keep an eye out for it in future releases.