Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests after updating the apigee_edge module. #1

Merged
merged 5 commits into from
Oct 22, 2018
Merged

Fixes tests after updating the apigee_edge module. #1

merged 5 commits into from
Oct 22, 2018

Conversation

Jaesin
Copy link
Contributor

@Jaesin Jaesin commented Oct 17, 2018

There was a changes to how the credentials are stored in the apigee_edge module that broke the tests for this module.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Jaesin
Copy link
Contributor Author

Jaesin commented Oct 17, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Jaesin
Copy link
Contributor Author

Jaesin commented Oct 17, 2018

@cnovak It doesn't appear that void-- has the necessary permissions to review/merge a PR.

Copy link
Collaborator

@cnovak cnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants