Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Implicit incompatible float to int conversion #378

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Fix for Implicit incompatible float to int conversion #378

merged 1 commit into from
Jun 1, 2022

Conversation

divya-intelli
Copy link
Collaborator

@divya-intelli divya-intelli commented May 27, 2022 •
edited
Loading

Fixes #377

raakesh-blokhra
raakesh-blokhra approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@raakesh-blokhra raakesh-blokhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@divya-intelli divya-intelli merged commit ef560bd into apigee:2.x Jun 1, 2022
@divya-intelli divya-intelli deleted the float-int branch June 1, 2022 14:58
@phdhiren phdhiren added this to the 2.0.2 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raakesh-blokhra raakesh-blokhra raakesh-blokhra approved these changes

@phdhiren phdhiren Awaiting requested review from phdhiren

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

[PHP8.1] Exception: Deprecated function: Implicit conversion from float to int loses precision
3 participants
@divya-intelli @raakesh-blokhra @phdhiren