Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for slow download of rate plan listing page when there are multiple rateplans #410

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

divya-intelli
Copy link
Collaborator

Fixes #409

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #410 (c639f0c) into 2.x (87a6478) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #410   +/-   ##
=========================================
  Coverage     51.21%   51.21%           
  Complexity     1987     1987           
=========================================
  Files           200      200           
  Lines          5694     5694           
=========================================
  Hits           2916     2916           
  Misses         2778     2778           
Impacted Files Coverage Δ
src/Entity/ParamConverter/XRatePlanConverter.php 81.81% <ø> (ø)
...Storage/Controller/XRatePlanSdkControllerProxy.php 55.17% <ø> (ø)
src/Entity/Storage/XProductStorage.php 62.16% <ø> (ø)
src/Entity/Storage/XRatePlanStorage.php 73.21% <ø> (ø)
src/Controller/BuyApiController.php 96.55% <100.00%> (ø)
src/Entity/XRatePlan.php 75.15% <100.00%> (ø)

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit 559f109 into apigee:2.x Dec 12, 2022
@divya-intelli divya-intelli added this to the 2.0.4 milestone Dec 21, 2022
@divya-intelli divya-intelli deleted the issue-409 branch June 12, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate plan listing takes time to load
2 participants