Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for phpcs failing in github action #433

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

divya-intelli
Copy link
Collaborator

Fixes #432

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #433 (aa286e4) into 2.x (55855eb) will decrease coverage by 8.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #433      +/-   ##
============================================
- Coverage     49.24%   40.74%   -8.51%     
  Complexity     1997     1997              
============================================
  Files           200      200              
  Lines          7398     7398              
============================================
- Hits           3643     3014     -629     
- Misses         3755     4384     +629     
Impacted Files Coverage Δ
...es/apigee_m10n_add_credit/src/AddCreditService.php 21.12% <ø> (-0.34%) ⬇️
...Entity/Access/AddCreditLogAccessControlHandler.php 0.00% <ø> (ø)
...apigee_m10n_add_credit/src/Entity/AddCreditLog.php 82.11% <ø> (ø)
...entSubscriber/CommerceCurrencyConfigSubscriber.php 16.43% <ø> (-16.44%) ⬇️
...e_m10n_add_credit/src/Form/AddCreditConfigForm.php 0.00% <ø> (ø)
...pigee_m10n_add_credit/src/Form/BillingTypeForm.php 0.00% <ø> (ø)
...gee_m10n_add_credit/src/Form/ConfirmUpdateForm.php 0.00% <ø> (ø)
..._add_credit/src/Form/GeneralSettingsConfigForm.php 0.00% <ø> (ø)
...n/Requirement/Requirement/AddCreditProductType.php 1.65% <ø> (ø)
...ugin/Requirement/Requirement/AddCreditProducts.php 20.58% <ø> (ø)
... and 32 more

... and 28 files with indirect coverage changes

@giteshk giteshk merged commit ba7f0bf into apigee:2.x Jun 20, 2023
divya-intelli added a commit that referenced this pull request Jun 27, 2023
* fix for phcs issue (#433)

* fix for deprecated hook hook_field_widget_form_alter (#435)
@divya-intelli divya-intelli added this to the 2.1.0 milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPCS is failing in Github action
2 participants